| Discussion Forum: Thread 174988 |
|
 |
| | | Author: | lovaquero  | | Posted: | Aug 21, 2014 12:09 | | Subject: | Store View Tabs Missing [SOLUTION] | | Viewed: | 174 times | | Topic: | Suggestions | | Status: | Discarded | |
|
| (Below is the solution to fix the missing tabs problem that currently exists
on Bricklink. It is a copy of the message I sent to admin. Posting it here for
more visibility. It took me longer to make the images and type the note explaining
the solution than it took to find the problem...)
The root cause is directly related to the addition of the 'link' that
switches the pages from Engling Chinese. It forces the HTML table to take
up more space than is necessary, thus pushing the table the contains the tabs
out of the viewable area. The images show the code - it is a true (and badly
done) hack.
Anyway, enough commenaty, here is the fix:
Bricklink Developers & Admin -
Attached is an image detailing the a solution that will correct the tab rendering
(hidden tabs) problem experienced on certain browsers. The problem is a rendering
difference between browsers related to how they interpret and implement HTML/CSS.
------------------------------------------------
The Root Cause is a combination of the following:
------------------------------------------------
1 - HTML4 v HTML5 support on BL (related to Splash page problems as well)
2 - Old ASP framework code v Modern HTML/CSS standards
3 - A really bad code hack to provide the link to switch to Chinese BL (I mean
no offence - there is no other way to describe it)
4 - Insuffient testing before release.
--------
Code Fix:
--------
#1 - Change the table tag's CELLPADDING attibute from CELLPADDING="5" to
CELLPADDING="0" (It is not needed, but the 10px vertical pixels it frees up are
needed
#2 - ADD "margin:0;padding:0;" to the style attribute of the UL tag utilized
to implement the Chinese language switch (most browsers will automatically do
this, others will not until forced to. This will stop the parent table from
pushing the tabs out of the viewable space in the top frame.
#3 - Add VALIGN="TOP" to the TD tag that wraps the section containing the Store
flags. This will force the flag images to the top of the table, similar to what
is done with the BL logo
Another temp solution is to set SCROLLING="YES" for the FRAME that loads the
store banner and tabs. This would also allow folks to atleast scroll down the
tabs
The Permenant solution is to fix the code hack used to implement the Chinese
language page link. It is improperly implemented - you shouldn't be using
UL LI to create the script link, and there are better ways to align the link
beyond using 10x not-breaking spaces...
Thank you
Rodney Pearson
Lovaquero
|
|
|
|
| | | | | |
| | | | | Author: | lovaquero | | Posted: | Aug 21, 2014 12:17 | | Subject: | Re: Store View Tabs Missing [SOLUTION] | | Viewed: | 61 times | | Topic: | Suggestions | |
|
| A (hopefully) more readable image of the code mentioned above.
Apologies on the typos in the OP - I am used to my customize code editor, and
not so much to document creation. 
|
|
|
| | | | | | | | | |
| | | | | | | Author: | QA_Ryan | | Posted: | Aug 21, 2014 12:21 | | Subject: | Re: Store View Tabs Missing [SOLUTION] | | Viewed: | 77 times | | Topic: | Suggestions | |
|
| In Suggestions, lovaquero writes:
| | A (hopefully) more readable image of the code mentioned above.
Apologies on the typos in the OP - I am used to my customize code editor, and
not so much to document creation.
|
Interesting, thanks Rodney! I forwarded this to the development team.
|
|
| | | | | |
| | | | | Author: | picabo | | Posted: | Aug 21, 2014 12:24 | | Subject: | Re: Store View Tabs Missing [SOLUTION] | | Viewed: | 81 times | | Topic: | Suggestions | |
|
| In Suggestions, lovaquero writes:
Thanks Rodney.
Pam
| | (Below is the solution to fix the missing tabs problem that currently exists
on Bricklink. It is a copy of the message I sent to admin. Posting it here for
more visibility. It took me longer to make the images and type the note explaining
the solution than it took to find the problem...)
The root cause is directly related to the addition of the 'link' that
switches the pages from Engling Chinese. It forces the HTML table to take
up more space than is necessary, thus pushing the table the contains the tabs
out of the viewable area. The images show the code - it is a true (and badly
done) hack.
Anyway, enough commenaty, here is the fix:
Bricklink Developers & Admin -
Attached is an image detailing the a solution that will correct the tab rendering
(hidden tabs) problem experienced on certain browsers. The problem is a rendering
difference between browsers related to how they interpret and implement HTML/CSS.
------------------------------------------------
The Root Cause is a combination of the following:
------------------------------------------------
1 - HTML4 v HTML5 support on BL (related to Splash page problems as well)
2 - Old ASP framework code v Modern HTML/CSS standards
3 - A really bad code hack to provide the link to switch to Chinese BL (I mean
no offence - there is no other way to describe it)
4 - Insuffient testing before release.
--------
Code Fix:
--------
#1 - Change the table tag's CELLPADDING attibute from CELLPADDING="5" to
CELLPADDING="0" (It is not needed, but the 10px vertical pixels it frees up are
needed
#2 - ADD "margin:0;padding:0;" to the style attribute of the UL tag utilized
to implement the Chinese language switch (most browsers will automatically do
this, others will not until forced to. This will stop the parent table from
pushing the tabs out of the viewable space in the top frame.
#3 - Add VALIGN="TOP" to the TD tag that wraps the section containing the Store
flags. This will force the flag images to the top of the table, similar to what
is done with the BL logo
Another temp solution is to set SCROLLING="YES" for the FRAME that loads the
store banner and tabs. This would also allow folks to atleast scroll down the
tabs
The Permenant solution is to fix the code hack used to implement the Chinese
language page link. It is improperly implemented - you shouldn't be using
UL LI to create the script link, and there are better ways to align the link
beyond using 10x not-breaking spaces...
Thank you
Rodney Pearson
Lovaquero
|
|
|
|
| | | | | |
| | | | | Author: | StarBrick | | Posted: | Aug 21, 2014 13:18 | | Subject: | Re: Store View Tabs Missing [SOLUTION] | | Viewed: | 51 times | | Topic: | Suggestions | |
|
| | Wow, did you post this to the helpdesk too? |
|
| | | | | | | | | |
| | | | | | | Author: | lovaquero | | Posted: | Aug 21, 2014 13:33 | | Subject: | Re: Store View Tabs Missing [SOLUTION] | | Viewed: | 49 times | | Topic: | Suggestions | |
|
| Yes - that is the first thing I did (the post above is a copy of that email).
And cs_ryan is on it as well 
In Suggestions, StarBrick writes:
| | Wow, did you post this to the helpdesk too?
|
|
|
| | | | | | | | | | | | | |
| | | | | | | | | Author: | StarBrick | | Posted: | Aug 21, 2014 14:03 | | Subject: | Re: Store View Tabs Missing [SOLUTION] | | Viewed: | 45 times | | Topic: | Suggestions | |
|
| Cool,
love the forum, love the members here!
Cheers!
|
|
| | | | | |
| | | | | Author: | lovaquero | | Posted: | Aug 21, 2014 15:10 | | Subject: | Re: Store View Tabs Missing [SOLUTION] | | Viewed: | 69 times | | Topic: | Suggestions | |
|
| I neglected to mention it before, but there IS a user-side workaround (at least
for IE users) to see the store view tabs. This should work until BL dev team
is able to implement a server-side permenant fix.
1 - Right-click on the store title
2 - Continue to right-click while moving your mouse down, as if you are highlighting
text for a copy/paste operation
3 - You will managage to force the hidden-scrollable table to scroll upward,
revealing the store tabs:
|
|
|
| | | | | | | | | |
| | | | | | | Author: | par016 | | Posted: | Aug 21, 2014 15:13 | | Subject: | Re: Store View Tabs Missing [SOLUTION] | | Viewed: | 37 times | | Topic: | Suggestions | |
|
| Good solution, but I think you mean left click.
-Pete
In Suggestions, lovaquero writes:
| | I neglected to mention it before, but there IS a user-side workaround (at least
for IE users) to see the store view tabs. This should work until BL dev team
is able to implement a server-side permenant fix.
1 - Right-click on the store title
2 - Continue to right-click while moving your mouse down, as if you are highlighting
text for a copy/paste operation
3 - You will managage to force the hidden-scrollable table to scroll upward,
revealing the store tabs:
|
|
|
| | | | | | | | | | | | | |
| | | | | | | | | Author: | lovaquero | | Posted: | Aug 21, 2014 15:40 | | Subject: | (Cancelled) | | Viewed: | 27 times | | Topic: | Suggestions | |
|
| | (Cancelled) |
|
| | | | | | | | | | | | | |
| | | | | | | | | Author: | lovaquero | | Posted: | Aug 21, 2014 15:42 | | Subject: | Re: Store View Tabs Missing [SOLUTION] | | Viewed: | 26 times | | Topic: | Suggestions | |
|
| Doh! Right, erm left you are!
I mean, yes - you are correct - I meant 'left-click'
/walks away grumbling about the English language
In Suggestions, par016 writes:
| | Good solution, but I think you mean left click.
-Pete
|
|
|
| | | | | | | | | |
| | | | | | | Author: | Andy_Bell | | Posted: | Aug 21, 2014 15:25 | | Subject: | Re: Store View Tabs Missing [SOLUTION] | | Viewed: | 30 times | | Topic: | Suggestions | |
|
| In Suggestions, lovaquero writes:
| | I neglected to mention it before, but there IS a user-side workaround (at least
for IE users) to see the store view tabs. This should work until BL dev team
is able to implement a server-side permenant fix.
1 - Right-click on the store title
2 - Continue to right-click while moving your mouse down, as if you are highlighting
text for a copy/paste operation
3 - You will managage to force the hidden-scrollable table to scroll upward,
revealing the store tabs:
|
This works fine for me:
ctrl +mouse wheel will zoom in or out
Just 1 zoom step should bring the tabs back into view.
AB
http://www.bricklink.com/message.asp?ID=847620
|
|
| | | | | | | | | | | | | |
| | | | | | | | | Author: | lovaquero | | Posted: | Aug 21, 2014 15:45 | | Subject: | Re: Store View Tabs Missing [SOLUTION] | | Viewed: | 32 times | | Topic: | Suggestions | |
|
| I tried this one with IE8 (win7 Pro, USB basic mouse), but it doesn't seem
to work. And I attempted the full range of zoom 10%-400% in steps and no luck.
What browser/OS are you using Andy?
|
|
| | | | | | | | | | | | | | | | | |
| | | | | | | | | | | Author: | Andy_Bell | | Posted: | Aug 22, 2014 10:14 | | Subject: | Re: Store View Tabs Missing [SOLUTION] | | Viewed: | 33 times | | Topic: | Suggestions | |
|
| In Suggestions, lovaquero writes:
| | I tried this one with IE8 (win7 Pro, USB basic mouse), but it doesn't seem
to work. And I attempted the full range of zoom 10%-400% in steps and no luck.
What browser/OS are you using Andy?
|
I typically use Chrome - it behaves the same as it has for a long time - in Chrome
at 110% the tabs are 50% hidden at 125% completely hidden - 100% show as expected.
In Firefox no matter the zoom level the tabs show correctly. Same for IE
1920x1080 display size
Andy
|
|
|
| | | | | | | | | |
| | | | | | | Author: | BLUSER_36530 | | Posted: | Aug 22, 2014 09:52 | | Subject: | Re: Store View Tabs Missing [SOLUTION] | | Viewed: | 54 times | | Topic: | Suggestions | |
|
| In Suggestions, lovaquero writes:
| | I neglected to mention it before, but there IS a user-side workaround (at least
for IE users) to see the store view tabs. This should work until BL dev team
is able to implement a server-side permenant fix.
1 - Right-click on the store title
2 - Continue to right-click while moving your mouse down, as if you are highlighting
text for a copy/paste operation
3 - You will managage to force the hidden-scrollable table to scroll upward,
revealing the store tabs:
|
That works for me in Chrome/Vista. Thanx!
|
|
|
|
|
|
USA, Indiana
)
)
Netherlands, Gelderland
)
)
)
)
)
