Discussion Forum: Thread 148011

 Author: sir_eldren View Messages Posted By sir_eldren
 Posted: Feb 22, 2013 19:05
 Subject: Inventory change button fix for Chrome/FF?
 Viewed: 100 times
 Topic: Suggestions
 Status:Open
 Vote:[Yes|No]
Cancel Message
Cancel
Reply to Message
Reply
BrickLink
ID Card

sir_eldren (160)

Location:  USA, Washington
Member Since Contact Type Status
Dec 8, 2007 Contact Member Seller
Buying Privileges - OKSelling Privileges - OK
Store Closed Store: Binky's Building Supply
(I was prompted to post this in here because, well, it might solve an issue on
the site.)

I may have found the culprit behind the non-working inventory change form in
browsers outside of IE.

Upon much looking, I'm wondering if the code doesn't work in the more strict
browsers because the form tags are not nested correctly. I'm noticing that the
opening form tag for the inventory update form is enclosed inside the table with
the inventory categories. The table then closes, and then there are two new
tables below that contain the rest of the form for updating the inventory. Those
tables close, the submit and reset buttons are there, and then the form's closing
tag comes. In most browsers, they close tags inside block-level elements once
the block-level element is closed--the table is closing the form, rendering the
submit button at the bottom of the page a useless button without an action.
Thus, the extreme importance of properly nesting your tags. If a form is larger
than the table it's contained within, then the opening and ending form tags should
be outside of the element, not inside.

-Craig
 Author: BLUSER_369442 View Messages Posted By BLUSER_369442
 Posted: Feb 22, 2013 21:43
 Subject: Re: Inventory change button fix for Chrome/FF?
 Viewed: 49 times
 Topic: Suggestions
Cancel Message
Cancel
Reply to Message
Reply
BrickLink
ID Card

BLUSER_369442 (322)

Location:  USA, Texas
Member Since Contact Type Status
Dec 30, 2012 Contact Member Buyer
No Longer Registered
No Longer Registered
Not only is the form improperly nested, but the open tag is in a place where
it's not allowed to be to begin with. The immediate children of a table are restricted
to caption, colgroup, thead, tfoot, tbody, and tr. Nothing else is permitted.
And all of those elements also have restricted content, so the only way a form
can be inside a table is to contain it entirely in a single th or td element.
Either one of these errors will break most browsers. It only works in IE because
the sloppy legacy parser treats tags as feature switches instead of data enclosures.

So yeah, putting the form tags where they belong should fix the problem, unless
there's some other IE bug being exploited as well.
 Author: Timothy_Smith View Messages Posted By Timothy_Smith
 Posted: Jul 19, 2013 09:24
 Subject: Re: Inventory change button fix for Chrome/FF?
 Viewed: 20 times
 Topic: Suggestions
Cancel Message
Cancel
Reply to Message
Reply
BrickLink
ID Card

Timothy_Smith (1537)

Location:  USA, Colorado
Member Since Contact Type Status
Jul 9, 2003 Contact Member Seller
No Longer RegisteredNo Longer Registered
Store Closed Store: Front Range Link
No Longer Registered
In Suggestions, sir_eldren writes:
  (I was prompted to post this in here because, well, it might solve an issue on
the site.)

I may have found the culprit behind the non-working inventory change form in
browsers outside of IE.

Upon much looking, I'm wondering if the code doesn't work in the more strict
browsers because the form tags are not nested correctly. I'm noticing that the
opening form tag for the inventory update form is enclosed inside the table with
the inventory categories. The table then closes, and then there are two new
tables below that contain the rest of the form for updating the inventory. Those
tables close, the submit and reset buttons are there, and then the form's closing
tag comes. In most browsers, they close tags inside block-level elements once
the block-level element is closed--the table is closing the form, rendering the
submit button at the bottom of the page a useless button without an action.
Thus, the extreme importance of properly nesting your tags. If a form is larger
than the table it's contained within, then the opening and ending form tags should
be outside of the element, not inside.

-Craig

Bumping this because it's an easy fix to an annoying error.